Messages in this thread | | | Date | Wed, 9 Mar 2016 08:49:27 +0200 | Subject | Re: [RFC 2/7] Input: joystick - avoid fragile snprintf use | From | Andy Shevchenko <> |
| |
On Tue, Mar 8, 2016 at 10:40 PM, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > Passing overlapping src and dst buffers to snprintf is fragile, and > while it currently works for the special case of passing dst as the > argument corresponding to an initial "%s" in the format string, any > other use would very likely lead to chaos. It's easy enough to avoid, > so let's do that.
> static void analog_name(struct analog *analog) > { > - snprintf(analog->name, sizeof(analog->name), "Analog %d-axis %d-button", > + int ret = 0;
Assignment is not needed.
> + > + ret = scnprintf(analog->name, sizeof(analog->name), "Analog %d-axis %d-button",
-- With Best Regards, Andy Shevchenko
| |