lkml.org 
[lkml]   [2016]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC 7/7] USB: usbatm: avoid fragile and inefficient snprintf use
From
Date
Hello.

On 3/8/2016 11:40 PM, Rasmus Villemoes wrote:

> Passing overlapping source and destination is fragile, and in this
> case we can even simplify the code and avoid the huge stack buffer by
> using the %p extension for printing a small hex dump.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/usb/atm/usbatm.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
> index db322d9ccb6e..fb47f9883056 100644
> --- a/drivers/usb/atm/usbatm.c
> +++ b/drivers/usb/atm/usbatm.c
> @@ -1331,15 +1331,12 @@ MODULE_VERSION(DRIVER_VERSION);
> static int usbatm_print_packet(struct usbatm_data *instance,
> const unsigned char *data, int len)
> {
> - unsigned char buffer[256];
> - int i = 0, j = 0;
> + int i, j;
>
> for (i = 0; i < len;) {
> - buffer[0] = '\0';
> - sprintf(buffer, "%.3d :", i);
> - for (j = 0; (j < 16) && (i < len); j++, i++)
> - sprintf(buffer, "%s %2.2x", buffer, data[i]);
> - dev_dbg(&instance->usb_intf->dev, "%s", buffer);
> + j = min(16, len-i);

Kernel style assumes spaces on either side of the operators, like below, no?

> + dev_dbg(&instance->usb_intf->dev, "%.3d : %*ph", i, j, data + i);
> + i += j;
> }
> return i;
> }

MBR, Sergei

\
 
 \ /
  Last update: 2016-03-09 14:41    [W:0.134 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site