Messages in this thread Patch in this message | | | From | Weongyo Jeong <> | Subject | [PATCH] genirq: remove unnecessary memset() calls. | Date | Thu, 31 Mar 2016 12:15:03 -0700 |
| |
sprintf() and snprintf() implementation of kernel guarantees that its result is terminated with null byte if size is larger than 0. So we don't need to call memset() at all.
Signed-off-by: Weongyo Jeong <weongyo.linux@gmail.com> --- kernel/irq/proc.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index 4e1b947..90dfbca 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -311,7 +311,6 @@ void register_handler_proc(unsigned int irq, struct irqaction *action) !name_unique(irq, action)) return; - memset(name, 0, MAX_NAMELEN); snprintf(name, MAX_NAMELEN, "%s", action->name); /* create /proc/irq/1234/handler/ */ @@ -340,7 +339,6 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc) if (desc->dir) goto out_unlock; - memset(name, 0, MAX_NAMELEN); sprintf(name, "%d", irq); /* create /proc/irq/1234 */ @@ -386,7 +384,6 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc) #endif remove_proc_entry("spurious", desc->dir); - memset(name, 0, MAX_NAMELEN); sprintf(name, "%u", irq); remove_proc_entry(name, root_irq_dir); } -- 2.1.3
| |