Messages in this thread Patch in this message | | | From | Paul Gortmaker <> | Subject | [PATCH] drivers/iommu: don't select DEBUG_FS for AMD_IOMMU_STATS | Date | Sat, 26 Mar 2016 21:18:44 -0400 |
| |
We have at least one big banner telling people that they should not deploy production kernels with DEBUG options enabled, but at the same time, we make it hard for people to turn DEBUG_FS off when we select (vs. depend on) the CONFIG_DEBUG_FS option.
Since we actively discourage people using debug-like features on any builds that are production oriented (see trace_printk banner for one example), so a generic sounding option should not select DEBUG_FS.
Since this is not a system critical option, convert it from a select to a depend -- this makes it nicer for us old school folk who edit .config and then run "make oldconfig" as a (bad?) habit.
Cc: Joerg Roedel <joro@8bytes.org> Cc: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> Cc: iommu@lists.linux-foundation.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/iommu/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index dd1dc39f84ff..959032bdbe12 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -126,8 +126,7 @@ config AMD_IOMMU config AMD_IOMMU_STATS bool "Export AMD IOMMU statistics to debugfs" - depends on AMD_IOMMU - select DEBUG_FS + depends on AMD_IOMMU && DEBUG_FS ---help--- This option enables code in the AMD IOMMU driver to collect various statistics about whats happening in the driver and exports that -- 2.6.1
| |