lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drm/amd/powerplay: fix memory leak on tdp_table
Date
From: Colin Ian King <colin.king@canonical.com>

tdp_table is being leaked on an error exit return path,
fix this by kfree'ing it. Also swap comparison around to make the
patch warning free with checkpatch.

Leak found via static analysis with CoverityScan

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c
index 34f4bef..40b7679 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c
@@ -512,8 +512,10 @@ static int get_cac_tdp_table(

hwmgr->dyn_state.cac_dtp_table = kzalloc(table_size, GFP_KERNEL);

- if (NULL == hwmgr->dyn_state.cac_dtp_table)
+ if (hwmgr->dyn_state.cac_dtp_table == NULL) {
+ kfree(tdp_table);
return -ENOMEM;
+ }

memset(hwmgr->dyn_state.cac_dtp_table, 0x00, table_size);

--
2.7.3
\
 
 \ /
  Last update: 2016-03-22 00:41    [W:0.790 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site