Messages in this thread Patch in this message | | | From | Jarkko Sakkinen <> | Subject | [PATCH] tpm, tpm_crb: remove wmb()'s | Date | Mon, 14 Mar 2016 20:34:46 +0200 |
| |
wmbs are not neded as we use iowrite32().
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> --- drivers/char/tpm/tpm_crb.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index a12b319..1cabe30 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -153,9 +153,6 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, size_t len) memcpy_toio(priv->cmd, buf, len); - /* Make sure that cmd is populated before issuing start. */ - wmb(); - if (priv->flags & CRB_FL_CRB_START) iowrite32(cpu_to_le32(CRB_START_INVOKE), &priv->cca->start); @@ -171,9 +168,6 @@ static void crb_cancel(struct tpm_chip *chip) iowrite32(cpu_to_le32(CRB_CANCEL_INVOKE), &priv->cca->cancel); - /* Make sure that cmd is populated before issuing cancel. */ - wmb(); - if ((priv->flags & CRB_FL_ACPI_START) && crb_do_acpi_start(chip)) dev_err(&chip->dev, "ACPI Start failed\n"); -- 2.7.0
| |