Messages in this thread Patch in this message | | | Date | Tue, 09 Feb 2016 15:40:16 -0500 | From | Steven Rostedt <> | Subject | [PATCH 3/4] tools lib traceevent: Set int_array fields to NULL if freeing from error |
| |
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Had a bug where on error of parsing __print_array() where the fields are freed after they were allocated, but since they were not set to NULL, the freeing of the arg also tried to free the already freed fields causing a double free.
Fix process_hex() while at it.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- tools/lib/traceevent/event-parse.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index f49b266b3978..e39a616f695b 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -2634,6 +2634,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok) free_field: free_arg(arg->hex.field); + arg->hex.field = NULL; out: *tok = NULL; return EVENT_ERROR; @@ -2658,8 +2659,10 @@ process_int_array(struct event_format *event, struct print_arg *arg, char **tok) free_size: free_arg(arg->int_array.count); + arg->int_array.count = NULL; free_field: free_arg(arg->int_array.field); + arg->int_array.field = NULL; out: *tok = NULL; return EVENT_ERROR; -- 2.6.4
| |