Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 5 Aug 2016 15:36:55 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/4] tools lib traceevent: Use USECS_PER_SEC instead of hardcoded number |
| |
Em Fri, Aug 05, 2016 at 02:19:42PM -0400, Steven Rostedt escreveu: > On Wed, 2 Mar 2016 09:20:04 -0300 > Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > > Em Tue, Feb 09, 2016 at 03:40:15PM -0500, Steven Rostedt escreveu: > > > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > > > > > Instead of using 1000000, define a USECS_PER_SEC macro and use that instead. > > > > Applying, but the kernel uses USEC_PER_SEC, NSEC_PER_SEC, etc, at some > > point I'll try and get those same headers in tools/include/ and make all > > of tools/ use the same convention as the kernel. > > Was this ever applied? Anyway, I'll also go ahead and convert this to > the non plural versions to match the kernel.
Fell thru the cracks :-\ The other patches in the series were applied tho.
I'm introducing this and removing the definitions I have in tools/perf/perf.h for NSEC_PER_SEC and NSEC_PER_USEC:
[acme@jouet linux]$ cat tools/include/linux/time64.h #ifndef _TOOLS_LINUX_TIME64_H #define _TOOLS_LINUX_TIME64_H
#define MSEC_PER_SEC 1000L #define USEC_PER_MSEC 1000L #define NSEC_PER_USEC 1000L #define NSEC_PER_MSEC 1000000L #define USEC_PER_SEC 1000000L #define NSEC_PER_SEC 1000000000L #define FSEC_PER_SEC 1000000000000000LL
#endif /* _TOOLS_LINUX_TIME64_H */ [acme@jouet linux]$
So the header to include is the same as in the kernel, the constants as well. We can go on adding more stuff from include/linux/time64.h as tools use it.
- Arnaldo
| ![\](/images/icornerr.gif) |