lkml.org 
[lkml]   [2016]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[report] invalid error code in do_register_con_driver() console
Hi Jiri,

I'm getting the following static checker warning:

drivers/tty/vt/vt.c:3588 do_register_con_driver()
warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'

drivers/tty/vt/vt.c
3582 if (retval)
3583 goto err;
3584
3585 desc = csw->con_startup();
3586
3587 if (!desc)
3588 goto err;
3589
3590 retval = -EINVAL;
3591

Probably, we could more the "retval = -EINVAL;" before the goto? I
don't think it's intentional?

regards,
dan carpenter

\
 
 \ /
  Last update: 2016-02-25 23:21    [W:0.038 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site