lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: Add workaround for Cavium erratum 27456
On 02/10/2016 01:28 AM, Will Deacon wrote:
> On Tue, Feb 09, 2016 at 11:29:16AM -0800, David Daney wrote:
>> From: Andrew Pinski <apinski@cavium.com>
>>
>> On ThunderX T88 pass 1.x through 2.1 parts, broadcast TLBI
>> instructions may cause the icache to become invalid if it contains
>> data for a non-current ASID.
>>
>> This patch implements the workaround (which flushes the local icache
>> when switching the mm) by using code patching.
>
> So, to be clear, is this "just" a performance problem as opposed to a
> correctness issue?

No. It is a correctness issue. Without this workaround in place,
userspace programs end up executing the wrong instructions, which leads
to unpredictable behavior and program crashes.


> If so, do you have any numbers with and without this
> change?

We tried to measure it, but the impact is not measurable in the tests we
have done. Switching the mm is not often done so the extra ICache
invalidation is rare.

Also note that for the non-workaround case, the code path is unchanged.
Since the following function (__cpu_setup()) is not on the hot path of
anything, any extra ICache pressure from the three NOPs is unlikely to
matter.

>
> Will
>

\
 
 \ /
  Last update: 2016-02-10 19:21    [W:0.077 / U:1.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site