lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code
On Wed, 10 Feb 2016 14:23:33 +0100
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Wed, 10 Feb 2016 14:08:43 +0100
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>
> > But you are right, there is a bug: we should rollback if vhost_init_used()
> > fails. Something like below:
> >
> > err_used:
> > vq->private_data = oldsock;
> > vhost_net_enable_vq(n, vq);
> > + vhost_adjust_vring_endian(vq);
>
> Shouldn't we switch back before we reenable? Or have I lost myself in
> this maze here again?
>

I haven't spotted any path under vhost_net_enable_vq() that needs
the vring endianness, but indeed it looks safer to switch back
before a worker thread may be woken up.

> > if (ubufs)
> > vhost_net_ubuf_put_wait_and_free(ubufs);
> > err_ubufs:

\
 
 \ /
  Last update: 2016-02-10 15:01    [W:0.057 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site