Messages in this thread | | | Date | Wed, 10 Feb 2016 14:23:33 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code |
| |
On Wed, 10 Feb 2016 14:08:43 +0100 Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> But you are right, there is a bug: we should rollback if vhost_init_used() > fails. Something like below: > > err_used: > vq->private_data = oldsock; > vhost_net_enable_vq(n, vq); > + vhost_adjust_vring_endian(vq);
Shouldn't we switch back before we reenable? Or have I lost myself in this maze here again?
> if (ubufs) > vhost_net_ubuf_put_wait_and_free(ubufs); > err_ubufs:
| |