Messages in this thread | | | Date | Mon, 5 Dec 2016 22:24:51 +0100 | From | Stefan Eichenberger <> | Subject | Re: [PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation |
| |
Hi Vivien
On Mon, Dec 05, 2016 at 11:27:02AM -0500, Vivien Didelot wrote: > static const struct mv88e6xxx_ops mv88e6097_ops = { > @@ -3285,6 +3266,7 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { > .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, > .g1_set_egress_port = mv88e6095_g1_set_egress_port, > .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, > + .reset = mv88e6185_g1_reset, > };
Because it is not necessary to disable/enable the PPU and bit 14 is marked as reserved in the datasheet, I think the following should be used instead: .reset = mv88e6352_g1_reset
Regards, Stefan
| |