Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations | Date | Mon, 05 Dec 2016 17:18:19 -0500 |
| |
Stefan Eichenberger <eichest@gmail.com> writes:
> Hi Vivien, > > On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: >> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { >> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, >> .g1_set_egress_port = mv88e6095_g1_set_egress_port, >> .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, >> + .ppu_enable = mv88e6185_g1_ppu_enable, >> + .ppu_disable = mv88e6185_g1_ppu_disable, >> .reset = mv88e6185_g1_reset, >> }; > > The mv88e6097 should use the indirect access to the phys, bit 14 in g1 > control is marked as reserved. They write in the datasheet that > disabling the PPU is still supported but indirect access via g2 should > be used because disabling the PPU is no longer recommended.
Ho ok thanks, I respin a v3 right away with this removed and with mv88e6352_g1_reset instead.
Vivien
| |