Messages in this thread | | | Date | Sat, 17 Dec 2016 17:32:12 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v3 2/2] dt-bindings: power: add bindings for sbs-charger |
| |
Hi,
On Thu, Nov 24, 2016 at 01:33:43PM +0100, Nicolas Saenz Julienne wrote: > Adds device tree documentation for SBS charger compilant devices as defined > here: http://sbs-forum.org/specs/sbc110.pdf > > Signed-off-by: Nicolas Saenz Julienne <nicolas.saenz@prodys.net> > --- > v2 -> v3: > - add part number as compatible > > .../bindings/power/supply/sbs_sbs-charger.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt > new file mode 100644 > index 0000000..f6b6027 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt > @@ -0,0 +1,24 @@ > +SBS sbs-charger > +~~~~~~~~~~ > + > +Required properties: > + - compatible: should contain one of the following: > + - "lltc,ltc4100" > + - "sbs,sbs-charger"
That's not what I meant. The idea is to specify "lltc,ltc4100" with "sbs,sbs-charger" as fallback. Then the driver for now only handles "sbs,sbs-charger", but if any vendor registers need to be supported we have a more specific compatible value in DT, that can be used to identify the device.
> +Optional properties: > +- interrupt-parent: Should be the phandle for the interrupt controller. Use in > + conjunction with "interrupts". > +- interrupts: Interrupt mapping for GPIO IRQ. Use in conjunction with > + "interrupt-parent". If an interrupt is not provided the driver will switch > + automatically to polling. > + > +Example: > + > + ltc4100@9 { > + compatible = "sbs,sbs-charger"; > + reg = <0x9>; > + interrupt-parent = <&gpio6>; > + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; > + };
So the example would look like
compatible = "lltc,ltc4100", "sbs,sbs-charger";
-- Sebastian [unhandled content-type:application/pgp-signature] | |