Messages in this thread Patch in this message | | | From | Shaohua Li <> | Subject | [PATCH] block_dev: don't update file access position for sync direct IO | Date | Tue, 13 Dec 2016 19:07:55 -0800 |
| |
For sync direct IO, generic_file_direct_write/generic_file_read_iter will update file access position. Don't duplicate the update in .direct_IO. This cause my raid array can't assemble.
Cc: Christoph Hellwig <hch@lst.de> Cc: Jens Axboe <axboe@fb.com> Signed-off-by: Shaohua Li <shli@fb.com> --- fs/block_dev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c index 95acbd2..1eb7dcf 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -264,7 +264,6 @@ __blkdev_direct_IO_simple(struct kiocb *iocb, struct iov_iter *iter, if (unlikely(bio.bi_error)) return bio.bi_error; - iocb->ki_pos += ret; return ret; } @@ -411,10 +410,8 @@ __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter, int nr_pages) __set_current_state(TASK_RUNNING); ret = dio->bio.bi_error; - if (likely(!ret)) { + if (likely(!ret)) ret = dio->size; - iocb->ki_pos += ret; - } bio_put(&dio->bio); return ret; -- 2.9.3
| |