lkml.org 
[lkml]   [2016]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectlinux-next: build warning after merge of the overlayfs tree
Hi Miklos,

After merging the overlayfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from fs/overlayfs/dir.c:20:0:
fs/overlayfs/dir.c: In function 'ovl_set_redirect':
fs/overlayfs/overlayfs.h:92:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
int err = vfs_setxattr(dentry, name, value, size, flags);
^
fs/overlayfs/dir.c:788:14: note: 'ret' was declared here
char *buf, *ret;
^

Introduced by commit

496654b0792e ("ovl: redirect on rename-dir")

This is not necessarily a false positive (although is is a confusing
message): if the kmalloc of "buf" fails and samedir was not set in
ovl_get_redirect(), then "return ret" will be executed but "ret" has
not been set.

--
Cheers,
Stephen Rothwell

\
 
 \ /
  Last update: 2016-11-22 01:20    [W:0.030 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site