Messages in this thread | | | Subject | Re: [PATCH v2 2/3] iio: light: opt3001: trivial type refactoring | From | Jonathan Cameron <> | Date | Sun, 24 Jan 2016 15:02:06 +0000 |
| |
On 16/01/16 16:14, Alexander Koch wrote: > Change variable type of struct opt3001 members 'ok_to_ignore_lock' and > 'result_ready' uint16-bitfield of length one to bool. > > They are used as bool, let the compiler do the optimization. > > Signed-off-by: Alexander Koch <mail@alexanderkoch.net> > Signed-off-by: Michael Hornung <mhornung.linux@gmail.com> I find it hard to care much about this one, but consistency is always good and the bitfield never made much sense in here.
Applied to the togreg branch of iio.git - pushed out as testing... etc.
Thanks,
Jonathan > --- > drivers/iio/light/opt3001.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c > index aefbd79..b05c484 100644 > --- a/drivers/iio/light/opt3001.c > +++ b/drivers/iio/light/opt3001.c > @@ -79,8 +79,8 @@ struct opt3001 { > struct device *dev; > > struct mutex lock; > - u16 ok_to_ignore_lock:1; > - u16 result_ready:1; > + bool ok_to_ignore_lock; > + bool result_ready; > wait_queue_head_t result_ready_queue; > u16 result; > >
| |