Messages in this thread | | | Date | Tue, 8 Sep 2015 23:12:50 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH 2/2] staging: lustre: lov: remove always false condition |
| |
On Tue, Sep 08, 2015 at 09:53:09AM -0700, Joe Perches wrote: > On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote: > > if (qctl->qc_valid == QC_OSTIDX) { > > - if (qctl->qc_idx < 0 || count <= qctl->qc_idx) > > + if (count <= qctl->qc_idx) > > Perhaps this test would be clearer reversed too > > if (qctl->qc_idx >= count) There are more such comparison in that file, like: 1) if (ost_idx >= lov->desc.ld_tgt_count) 2) if (index >= lov->lov_tgt_size) and some more. And if I include it in this patch then it will become separate change. I will better send a separate patch for this.
Regards Sudip
| |