Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH 2/2] staging: lustre: lov: remove always false condition | Date | Tue, 8 Sep 2015 21:53:02 +0530 |
| |
The member qc_idx of struct if_quotactl is unsigned and hence it can never be less than zero.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/staging/lustre/lustre/lov/lov_obd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c index 2a2fd8d..906503b 100644 --- a/drivers/staging/lustre/lustre/lov/lov_obd.c +++ b/drivers/staging/lustre/lustre/lov/lov_obd.c @@ -1487,7 +1487,7 @@ static int lov_iocontrol(unsigned int cmd, struct obd_export *exp, int len, struct obd_quotactl *oqctl; if (qctl->qc_valid == QC_OSTIDX) { - if (qctl->qc_idx < 0 || count <= qctl->qc_idx) + if (count <= qctl->qc_idx) return -EINVAL; tgt = lov->lov_tgts[qctl->qc_idx]; -- 1.9.1
| |