Messages in this thread Patch in this message | | | From | Muhammad Falak R Wani <> | Subject | [PATCH v1] usb: core: driver: Use kmalloc_array | Date | Mon, 7 Sep 2015 21:30:25 +0530 |
| |
Use kmalloc_array instead of kmalloc to allocate memory for an array. Also, remove the dev_warn for a memory leak, making the if check more sleek.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> --- On suggestion by Joe Perches <joe@perches.com>
Changes since v0 -remove dev_warn for memory leak -remove unnecessary parens for if --- drivers/usb/core/driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 818369a..e0636c1 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -416,12 +416,10 @@ static int usb_unbind_interface(struct device *dev) if (ep->streams == 0) continue; if (j == 0) { - eps = kmalloc(USB_MAXENDPOINTS * sizeof(void *), + eps = kmalloc_array(USB_MAXENDPOINTS, sizeof(void *), GFP_KERNEL); - if (!eps) { - dev_warn(dev, "oom, leaking streams\n"); + if (!eps) break; - } } eps[j++] = ep; } -- 1.9.1
| |