Messages in this thread | | | From | Aravind Gopalakrishnan <> | Subject | [PATCH V2 0/3] Updates to mce_amd_inj module | Date | Fri, 25 Sep 2015 09:20:48 -0500 |
| |
This patchset is mostly a resend of earlier patches which got acceptance into maintainer's tree but did not make it into upstream. Original versions of patches 2 and 3 of this patchset- a. http://marc.info/?l=linux-edac&m=143327679901253&w=2 b. http://marc.info/?l=linux-edac&m=143392472509250&w=2
Changes from original versions- Patch 2: Earlier version did not include the update to README file. That was because README attribute was introduced in separate patch (http://marc.info/?l=linux-edac&m=143327679301249&w=2) But subsequently, only parts of it made it upstream.
Patch 3: NBCFG register offset definition exists already in drivers/edac/amd64_edac.h which was included in earlier version. But any dependency with drivers/edac/ was removed when the file moved to arch/x86/ras. So, I have redefined it here. I can move it to a different place if required.
With changes to the location of the module, I am adapting the patches on top of latest tip.
Patch 1: Abort write file operation on invalid input Patch 2: Extend flags attribute to accept values of 'df', 'th'. These values will be used to trigger deferred error/threshold error apic interrupts respectively. Patch 3: Modify injection mechanism for bank 4 errors. Since they are logged or reported only on NBC, we make sure that we inject on the correct core here.
Changes from V1 (per Boris' comments) - Instead of ignoring unwanted characters, return early on wrong input from user as this way, we can save a copy from user input for bad values. - With above change, modified patch title and commit message a bit. - Use 2 letter strings to indicate error injection for Deferred/Threshold error interrupts too.
Aravind Gopalakrishnan (3): RAS, mce_amd_inj: Return early on invalid input RAS, mce_amd_inj: Add capability to trigger apic interrupts RAS, mce_amd_inj: Inject errors on NBC for bank 4 errors
arch/x86/ras/mce_amd_inj.c | 109 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 102 insertions(+), 7 deletions(-)
-- 2.4.0
| |