Messages in this thread | | | Date | Thu, 24 Sep 2015 12:49:19 +0900 | From | Sergey Senozhatsky <> | Subject | Re: + zsmalloc-add-comments-for-inuse-to-zspage.patch added to -mm tree |
| |
On (09/23/15 14:53), akpm@linux-foundation.org wrote: > ------------------------------------------------------ > From: Hui Zhu <zhuhui@xiaomi.com> > Subject: zsmalloc: add comments for ->inuse to zspage > > Signed-off-by: Hui Zhu <zhuhui@xiaomi.com> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Cc: Dan Streetman <ddstreet@ieee.org> > Cc: Minchan Kim <minchan@kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > mm/zsmalloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff -puN mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage mm/zsmalloc.c > --- a/mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage > +++ a/mm/zsmalloc.c > @@ -38,6 +38,7 @@ > * page->lru: links together first pages of various zspages. > * Basically forming list of zspages in a fullness group. > * page->mapping: class index and fullness group of the zspage > + * page->inuse: the pages number that is used in this zspage
Probably arrived last night to my another mailbox, so haven't seen this one.
The comment is wrong. page ->inuse represents the number of objects in use in this zspage; not "the pages number".
usage example:
zspage_full() : page->inuse == page->objects obj_malloc() : first_page->inuse++ obj_free() : first_page->inuse--
-ss
| |