Messages in this thread | | | Date | Tue, 22 Sep 2015 14:30:06 -0400 | From | Tejun Heo <> | Subject | Re: [RFC v2 04/18] kthread: Add destroy_kthread_worker() |
| |
Hello,
On Mon, Sep 21, 2015 at 03:03:45PM +0200, Petr Mladek wrote: ... > Note that flush() does not guarantee that the queue is empty. drain() > is more safe. It returns when the queue is really empty. Also it warns
Maybe it'd be better to be a bit more specific. drain() is safer because it can handle self-requeueing work items.
> when too many work is being queued when draining. ... > +/** > + * destroy_kthread_worker - destroy a kthread worker > + * @worker: worker to be destroyed > + * > + * Destroy @worker. It should be idle when this is called.
So, no new work item should be queued from this point on but @worker is allowed to be not idle.
Thanks.
-- tejun
| |