lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC v2 09/18] mm/huge_page: Convert khugepaged() into kthread worker API
    Hello,

    On Mon, Sep 21, 2015 at 03:03:50PM +0200, Petr Mladek wrote:
    > +static int khugepaged_has_work(void)
    > +{
    > + return !list_empty(&khugepaged_scan.mm_head) &&
    > + khugepaged_enabled();
    > +}

    Hmmm... no biggie but this is a bit bothering.

    > @@ -425,7 +447,10 @@ static ssize_t scan_sleep_millisecs_store(struct kobject *kobj,
    > return -EINVAL;
    >
    > khugepaged_scan_sleep_millisecs = msecs;
    > - wake_up_interruptible(&khugepaged_wait);
    > + if (khugepaged_has_work())
    > + mod_delayed_kthread_work(khugepaged_worker,
    > + &khugepaged_do_scan_work,
    > + 0);

    What's wrong with just doing the following?

    if (khugepaged_enabled())
    mod_delayed_kthread_work(...);

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2015-09-22 22:41    [W:2.535 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site