lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v4 0/2] Driver for Microchip digital potentiometers
Date
From: Peter Rosin <peda@axentia.se>

This is the fourth attempt for a driver for these chips.

Thanks for review comments from Greg Kroah-Hartman, Crt Mori,
Daniel Baluta, Lars-Peter Clauson, Andreas Dannenberg and Peter
Meerwald. I think and hope I got it all sorted.

Changes since v3:
- Use i2c_smbus_read_word_swapped (Peter)
- Use devm_iio_device_register and drop the mcp4531_remove op (Peter)
- Add defines for a few magic numbers (Peter)
- Deduplicate channel params with a macro (Peter)
- Mention the i2c client address options (Peter)
- Whitespace and other trivial nits (Peter)

Changes since v2:
- Change naming from mcp4xxx_dpot to mcp4531 (Daniel)
- Added links to datasheet in commit message and source (Daniel)
- Rename from pot to potentiometer (Daniel, Crt)
- Use IIO_RESISTANCE instead of IIO_STEPS (Crt, Lars-Peter)
- Don't use wildcards in MAINTAINERS and point to the iio list (Crt)
- Avoid races by not caching values (Crt)
- Spell Microchip correctly (Andreas)

Changes since v1:
- Make it an IIO driver instead (Greg)
- Don't convolute the code with big obscure macros (Greg)
- Inline the bits from mcp4xxx_dpot.h that are actually used
and drop that file (me)
- Better Changelog (Greg)

Cheers,
Peter

Peter Rosin (2):
iio: resistance: Document that resistance can be output
iio: mcp4531: Driver for Microchip digital potentiometers

Documentation/ABI/testing/sysfs-bus-iio | 2 +
MAINTAINERS | 6 +
drivers/iio/Kconfig | 1 +
drivers/iio/Makefile | 1 +
drivers/iio/potentiometer/Kconfig | 20 ++++
drivers/iio/potentiometer/Makefile | 6 +
drivers/iio/potentiometer/mcp4531.c | 196 +++++++++++++++++++++++++++++++
7 files changed, 232 insertions(+)
create mode 100644 drivers/iio/potentiometer/Kconfig
create mode 100644 drivers/iio/potentiometer/Makefile
create mode 100644 drivers/iio/potentiometer/mcp4531.c

--
1.7.10.4



\
 
 \ /
  Last update: 2015-09-22 18:01    [W:0.057 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site