lkml.org 
[lkml]   [2015]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 0/7] x86/insn: perf tools: Add a few new x86 instructions
Em Wed, Sep 02, 2015 at 03:15:24PM +0300, Adrian Hunter escreveu:
> Changes in V2:
>
> perf tools: Display build warning if x86 instruction decoder differs from kernel
> New patch (slightly modified from the proposal and so without Jiri's Ack)

Applied.

But please consider doing some extra work on at least showing
what are the difference.

I think those diff calls should be moved to a separate shell script,
that would either do what they do now, i.e. show that one line "things
changed!" or would produce a diff file that would then have its contents
shown, this way one could go on removing such differences, building
again, rinse, repeat, till the warning is gone.

Thanks a lot!

- Arnaldo


\
 
 \ /
  Last update: 2015-09-02 22:21    [W:0.158 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site