Messages in this thread | | | Date | Wed, 2 Sep 2015 09:45:35 -0500 | From | Dimitri Sivanich <> | Subject | Re: [PATCH 3/4] drivers/misc/sgi-gru: remove always false condition |
| |
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Wed, Sep 02, 2015 at 04:54:57PM +0530, Sudip Mukherjee wrote: > The member gid in struct gru_dump_chiplet_state_req is unsigned int. So > it can never be less than 0. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/misc/sgi-gru/grukdump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c > index fa515e3..dbba197 100644 > --- a/drivers/misc/sgi-gru/grukdump.c > +++ b/drivers/misc/sgi-gru/grukdump.c > @@ -188,7 +188,7 @@ int gru_dump_chiplet_request(unsigned long arg) > return -EFAULT; > > /* Currently, only dump by gid is implemented */ > - if (req.gid >= gru_max_gids || req.gid < 0) > + if (req.gid >= gru_max_gids) > return -EINVAL; > > gru = GID_TO_GRU(req.gid); > -- > 1.9.1
| |