Messages in this thread | | | Date | Wed, 2 Sep 2015 09:44:35 -0500 | From | Dimitri Sivanich <> | Subject | Re: [PATCH 2/4] drivers/misc/sgi-gru: make functions static |
| |
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Wed, Sep 02, 2015 at 04:54:56PM +0530, Sudip Mukherjee wrote: > The functions gru_get_cb_exception_detail_str() and gru_abort() were > only called locally from that file. We can make them static. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/misc/sgi-gru/grukservices.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c > index 1f0bdab..a6fd773 100644 > --- a/drivers/misc/sgi-gru/grukservices.c > +++ b/drivers/misc/sgi-gru/grukservices.c > @@ -429,8 +429,8 @@ int gru_get_cb_exception_detail(void *cb, > return 0; > } > > -char *gru_get_cb_exception_detail_str(int ret, void *cb, > - char *buf, int size) > +static char *gru_get_cb_exception_detail_str(int ret, void *cb, > + char *buf, int size) > { > struct gru_control_block_status *gen = (void *)cb; > struct control_block_extended_exc_detail excdet; > @@ -505,7 +505,7 @@ int gru_wait_proc(void *cb) > return ret; > } > > -void gru_abort(int ret, void *cb, char *str) > +static void gru_abort(int ret, void *cb, char *str) > { > char buf[GRU_EXC_STR_SIZE]; > > -- > 1.9.1
| |