lkml.org 
[lkml]   [2015]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] regmap: fix compilation warning
Date
Explicitly initialize ret to -EINVAL in regmap_raw_read to fix the
following compilation warning:

CC drivers/base/regmap/regmap.o
linux/drivers/base/regmap/regmap.c: In function ‘regmap_raw_read’:
linux/drivers/base/regmap/regmap.c:2174:6: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
int ret, i;
^

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
drivers/base/regmap/regmap.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 7111d04..ba0aab4 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -2171,14 +2171,15 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
size_t val_bytes = map->format.val_bytes;
size_t val_count = val_len / val_bytes;
unsigned int v;
- int ret, i;
+ int i;
+ int ret = -EINVAL;

if (!map->bus)
- return -EINVAL;
+ return ret;
if (val_len % map->format.val_bytes)
- return -EINVAL;
+ return ret;
if (reg % map->reg_stride)
- return -EINVAL;
+ return ret;

map->lock(map->lock_arg);

--
1.8.3.1


\
 
 \ /
  Last update: 2015-09-02 13:21    [W:0.026 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site