Messages in this thread | | | Subject | Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue | From | Sergei Shtylyov <> | Date | Sat, 19 Sep 2015 19:09:57 +0300 |
| |
Hello.
On 9/18/2015 8:12 PM, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com> > > f_midi is not checking weather the is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> > --- > drivers/usb/gadget/function/f_midi.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index ad50a67..a5e446d 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req) > } > } > > - if (req->length > 0) > - usb_ep_queue(ep, req, GFP_ATOMIC); > + if (req->length > 0) { > + int err; > + > + err = usb_ep_queue(ep, req, GFP_ATOMIC); > + if (err < 0) > + ERROR(midi, "%s queue req: %d\n", > + midi->out_ep->name, err); > + } > else
} else {
> free_ep_req(ep, req);
}
> }
The lines added above show the proper kernel CodingStyle. } should be on the same line as *else* and {} should be used in all branches of the *if* statement if at least one branch has them.
MBR, Sergei
| |