lkml.org 
[lkml]   [2015]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
    Date
    From: "Felipe F. Tonello" <eu@felipetonello.com>

    f_midi is not checking weather the is an error on usb_ep_queue
    request, ignoring potential problems, such as memory leaks.

    Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
    ---
    drivers/usb/gadget/function/f_midi.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
    index ad50a67..a5e446d 100644
    --- a/drivers/usb/gadget/function/f_midi.c
    +++ b/drivers/usb/gadget/function/f_midi.c
    @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
    }
    }

    - if (req->length > 0)
    - usb_ep_queue(ep, req, GFP_ATOMIC);
    + if (req->length > 0) {
    + int err;
    +
    + err = usb_ep_queue(ep, req, GFP_ATOMIC);
    + if (err < 0)
    + ERROR(midi, "%s queue req: %d\n",
    + midi->out_ep->name, err);
    + }
    else
    free_ep_req(ep, req);
    }
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-09-18 19:41    [W:4.714 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site