Messages in this thread Patch in this message | | | Subject | [PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero | From | Axel Lin <> | Date | Fri, 18 Sep 2015 17:50:55 +0800 |
| |
It's pointless to test (cell->bit_offset || cell->bit_offset). nvmem_shift_read_buffer_in_place() should be called when (cell->bit_offset || cell->nbits).
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d3c6676..c39723a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -825,7 +825,7 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, return rc; /* shift bits in-place */ - if (cell->bit_offset || cell->bit_offset) + if (cell->bit_offset || cell->nbits) nvmem_shift_read_buffer_in_place(cell, buf); *len = cell->bytes; -- 2.1.4
| |