lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 0/3] lib/string: introduce match_string() helper
Hello,

On Tue, Sep 15, 2015 at 09:53:48AM +0300, Andy Shevchenko wrote:
> There are users of a simple string matching in the array. Let's do a common
> helper for that.
>
> Two users are updated in the series. one more is coming [1].
>
> [1] http://www.spinics.net/lists/kernel/msg2074265.html
>
> The series is compile tested.
>
> Andy Shevchenko (3):
> lib/string: introduce match_string() helper
> drm/edid: convert to use match_string() helper
> ata: hpt366: convert to use match_string() helper
>
> drivers/ata/pata_hpt366.c | 13 +++++--------
> drivers/gpu/drm/drm_edid_load.c | 17 ++++++-----------
> include/linux/string.h | 7 +++++++
> lib/string.c | 26 ++++++++++++++++++++++++++
> 4 files changed, 44 insertions(+), 19 deletions(-)

While increase in LOC isn't the only indicator, we're adding two
helper functions each for two usages. I'm not quite sure the addition
of helpers is paying off here.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-09-15 18:01    [W:0.075 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site