Messages in this thread | | | Subject | Re: [PATCH v1 0/3] lib/string: introduce match_string() helper | From | Andy Shevchenko <> | Date | Thu, 22 Oct 2015 14:33:59 +0300 |
| |
On Tue, 2015-09-15 at 11:35 -0400, Tejun Heo wrote: > Hello, > > On Tue, Sep 15, 2015 at 09:53:48AM +0300, Andy Shevchenko wrote: > > There are users of a simple string matching in the array. Let's do > > a common > > helper for that. > > > > Two users are updated in the series. one more is coming [1]. > > > > [1] http://www.spinics.net/lists/kernel/msg2074265.html > > > > The series is compile tested. > > > > Andy Shevchenko (3): > > lib/string: introduce match_string() helper > > drm/edid: convert to use match_string() helper > > ata: hpt366: convert to use match_string() helper > > > > drivers/ata/pata_hpt366.c | 13 +++++-------- > > drivers/gpu/drm/drm_edid_load.c | 17 ++++++----------- > > include/linux/string.h | 7 +++++++ > > lib/string.c | 26 ++++++++++++++++++++++++++ > > 4 files changed, 44 insertions(+), 19 deletions(-) > > While increase in LOC isn't the only indicator, we're adding two > helper functions each for two usages. I'm not quite sure the > addition > of helpers is paying off here.
Does the following sound better? (Btw, I left only one helper function)
drivers/ata/pata_hpt366.c | 13 +++++-------- drivers/base/property.c | 10 ++-------- drivers/gpu/drm/drm_edid_load.c | 17 ++++++----------- drivers/pinctrl/pinmux.c | 13 +++---------- drivers/power/ab8500_btemp.c | 11 +++-------- drivers/power/ab8500_charger.c | 11 +++-------- drivers/power/ab8500_fg.c | 11 +++-------- drivers/power/abx500_chargalg.c | 10 +++------- drivers/power/charger-manager.c | 27 ++++----------------------- include/linux/string.h | 2 ++ lib/string.c | 26 ++++++++++++++++++++++++++ 11 files changed, 60 insertions(+), 91 deletions(-)
> > Thanks. >
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |