lkml.org 
[lkml]   [2015]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/6] locking/qspinlock: relaxes cmpxchg & xchg ops in native code
On 09/11/2015 06:27 PM, Davidlohr Bueso wrote:
> On Fri, 11 Sep 2015, Waiman Long wrote:
>
>> @@ -46,7 +46,7 @@ static inline bool virt_queued_spin_lock(struct
>> qspinlock *lock)
>> if (!static_cpu_has(X86_FEATURE_HYPERVISOR))
>> return false;
>>
>> - while (atomic_cmpxchg(&lock->val, 0, _Q_LOCKED_VAL) != 0)
>> + while (atomic_cmpxchg_acquire(&lock->val, 0, _Q_LOCKED_VAL) != 0)
>> cpu_relax();
>
> This code has changed with Peter's recent ccas fix. And the whole
> virt_queued_spin_lock()
> thing will now be under pv configs. So this doesn't apply to native
> code anymore, so it
> looks like it should be dropped altogether.
>
> Thanks,
> Davidlohr

You are right. Patch 1 needs to be updated on top of PeterZ latest patch.

Cheers,
Longman


\
 
 \ /
  Last update: 2015-09-14 17:41    [W:0.565 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site