Messages in this thread Patch in this message | | | From | Alexander Kuleshov <> | Subject | [PATCH] lib/halfmd4: Use rol32 inline function in the ROUND macro | Date | Mon, 14 Sep 2015 01:00:32 +0600 |
| |
The <linux/bitops.h> provides rol32() inline function, let's use already predefined function instead of direct expression.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> --- lib/halfmd4.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/halfmd4.c b/lib/halfmd4.c index a8fe627..137e861 100644 --- a/lib/halfmd4.c +++ b/lib/halfmd4.c @@ -1,6 +1,7 @@ #include <linux/compiler.h> #include <linux/export.h> #include <linux/cryptohash.h> +#include <linux/bitops.h> /* F, G and H are basic MD4 functions: selection, majority, parity */ #define F(x, y, z) ((z) ^ ((x) & ((y) ^ (z)))) @@ -14,7 +15,7 @@ * Rotation is separate from addition to prevent recomputation */ #define ROUND(f, a, b, c, d, x, s) \ - (a += f(b, c, d) + x, a = (a << s) | (a >> (32 - s))) + (a += f(b, c, d) + x, a = rol32(a, s)) #define K1 0 #define K2 013240474631UL #define K3 015666365641UL -- 2.5.0
| |