Messages in this thread | | | Date | Thu, 10 Sep 2015 20:19:35 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in find_vma() |
| |
On 09/10, Chen Gang wrote: > > On 9/10/15 00:26, Oleg Nesterov wrote: > > > > The implementation looks correct. Why do you think it can be not 1st vma? > > > > It is in while (rb_node) {...}. > > - When we set "vma = tmp", it is alreay match "addr < vm_end".
Yes,
> - If "addr>= vm_start", we return this vma (else continue searching).
This is optimization, we can stop the search because in this case vma == tmp is obviously the 1st vma with "addr < vm_end".
I simply can't understand your concerns. Perhaps you can make a patch, then it will be more clear what me-or-you have missed.
Oleg.
| |