lkml.org 
[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] ACPICA: fix possible NULL dereference
Date
acpi_ns_get_secondary_object() can return NULL, and if it returns NULL
then we were dereferencing it while calling acpi_ds_execute_arguments().

Lets have a NULL check and return AE_NOT_EXIST.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/acpi/acpica/dsargs.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/acpi/acpica/dsargs.c b/drivers/acpi/acpica/dsargs.c
index e2ab59e..4bb8952 100644
--- a/drivers/acpi/acpica/dsargs.c
+++ b/drivers/acpi/acpica/dsargs.c
@@ -192,6 +192,9 @@ acpi_ds_get_buffer_field_arguments(union acpi_operand_object *obj_desc)
/* Get the AML pointer (method object) and buffer_field node */

extra_desc = acpi_ns_get_secondary_object(obj_desc);
+ if (!extra_desc)
+ return_ACPI_STATUS(AE_NOT_EXIST);
+
node = obj_desc->buffer_field.node;

ACPI_DEBUG_EXEC(acpi_ut_display_init_pathname(ACPI_TYPE_BUFFER_FIELD,
--
1.9.1


\
 
 \ /
  Last update: 2015-09-10 12:41    [W:0.032 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site