Messages in this thread | | | Date | Mon, 24 Aug 2015 09:18:37 -0700 | From | Brian Norris <> | Subject | Re: [PATCH 2/2] ubifs: Allow O_DIRECT |
| |
On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: > Now, some user-space fails when direct I/O is not supported.
I think the whole argument rested on what it means when "some user space fails"; apparently that "user space" is just a test suite (which can/should be fixed).
> We can > chose to fake direct I/O or fix user-space. The latter seems to be the > preferred course of actions, and you are correctly pointing the man > page. > > However, if > > 1. we are the only FS erroring out on O_DIRECT > 2. other file-systems not supporting direct IO just fake it > > we may just follow the crowd and fake it too. > > I am kind of trusting Richard here - I assume he did the research and > the above is the case, this is why I am fine with his patch. > > Does this logic seem acceptable to you? Other folk's opinion would be > great to hear.
Could work for me, though that doesn't seem ideal. Anyway, it now seems Christopher and Richard agree with me.
Regards, Brian
| |