Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 2/2] ubifs: Allow O_DIRECT | Date | Mon, 24 Aug 2015 13:19:24 -0400 |
| |
Brian Norris <computersforpeace@gmail.com> writes:
> On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: >> Now, some user-space fails when direct I/O is not supported. > > I think the whole argument rested on what it means when "some user space > fails"; apparently that "user space" is just a test suite (which > can/should be fixed).
Even if it wasn't a test suite it should still fail. Either the fs supports O_DIRECT or it doesn't. Right now, the only way an application can figure this out is to try an open and see if it fails. Don't break that.
Cheers, Jeff
| |