lkml.org 
[lkml]   [2015]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
Subjectcrypto: broken Kconfig option CRYPTO_NULL2
Hi Herbert,

your commit 149a39717dcc ("crypto: aead - Add type-safe geniv
init/exit helpers") has shown up in Linux next (i.e., next-20150818)
adding the following lines of code to crypto/Kconfig:

@@ -150,12 +152,15 @@ config CRYPTO_GF128MUL
[...]

+config CRYPTO_NULL2
+ select CRYPTO_ALGAPI2
+ select CRYPTO_BLKCIPHER2
+ select CRYPTO_HASH2
+

There are two problems with the option above: (1) It does not have a
type, (2) it selects other options without being a tristate/boolean,
see below:

scripts/kconfig/mconf Kconfig
crypto/Kconfig:159:warning: config symbol defined without type
crypto/Kconfig:160:warning: config symbol 'CRYPTO_NULL2' uses select,
but is not boolean or tristate
crypto/Kconfig:161:warning: config symbol 'CRYPTO_NULL2' uses select,
but is not boolean or tristate
crypto/Kconfig:162:warning: config symbol 'CRYPTO_NULL2' uses select,
but is not boolean or tristate


If you want to, I can send a trivial patch making it a boolean without prompt.

I detected this issue with undertaker-checkpatch (undertaker.cs.fau.de).

Kind regards,
Valentin


\
 
 \ /
  Last update: 2015-08-19 10:01    [W:0.027 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site