Messages in this thread | | | Date | Sat, 15 Aug 2015 22:23:05 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg |
| |
On Tue, Jun 16, 2015 at 10:28:12AM -0700, York Sun wrote: > Based on i2c-mux-gpio driver, similarly the register based mux > switch from one bus to another by setting a single register. > The register can be on PCIe bus, local bus, or any memory-mapped > address. > > Signed-off-by: York Sun <yorksun@freescale.com> > CC: Wolfram Sang <wsa@the-dreams.de> > CC: Peter Korsgaard <peter.korsgaard@barco.com>
Mostly good.
> +static int i2c_mux_reg_probe(struct platform_device *pdev) > +{ > + struct regmux *mux; > + struct i2c_adapter *parent; > + struct resource *res; > + int (*deselect)(struct i2c_adapter *, void *, u32); > + unsigned int initial_state, class;
gcc says:
drivers/i2c/muxes/i2c-mux-reg.c:182:15: warning: variable 'initial_state' set but not used [-Wunused-but-set-variable]
It seens you prepared for setting the initial state but don't do the actual set?
> +static struct platform_driver i2c_mux_reg_driver = { > + .probe = i2c_mux_reg_probe, > + .remove = i2c_mux_reg_remove, > + .driver = { > + .owner = THIS_MODULE,
coccicheck says:
drivers/i2c/muxes/i2c-mux-reg.c:288:3-8: No need to set .owner here. The core will do it.
> + .name = "i2c-mux-reg", > + }, > +};
Thanks,
Wolfram
| |