lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h
On Wed, Jul 8, 2015 at 8:11 PM, Alban Bedel <albeu@free.fr> wrote:
> We shouldn't include irqchip.h from outside of the drivers/irqchip
> directory. The irq driver should idealy be there, however this not
> trivial at the moment. We still need to support platforms without DT
> support and the interface to the DDR controller still use a custom
> arch specific API.
>
> For now just redefine the IRQCHIP_DECLARE macro to avoid the cross
> tree include.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>

The define was moved into linux/irqchip.h in
91e20b5040c67c51aad88cf87db4305c5bd7f79d, so all you can/need to do is
...
> ---
> arch/mips/ath79/irq.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c
> index afb0096..c5ad737 100644
> --- a/arch/mips/ath79/irq.c
> +++ b/arch/mips/ath79/irq.c
> @@ -17,7 +17,6 @@
> #include <linux/interrupt.h>
> #include <linux/irqchip.h>
> #include <linux/of_irq.h>
> -#include "../../../drivers/irqchip/irqchip.h"
>
> #include <asm/irq_cpu.h>
> #include <asm/mipsregs.h>

this removal ;)


Jonas


\
 
 \ /
  Last update: 2015-07-08 20:41    [W:0.033 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site