Messages in this thread | | | Date | Sat, 11 Jul 2015 22:36:26 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h |
| |
On Wed, 8 Jul 2015, Alban Bedel wrote: > We shouldn't include irqchip.h from outside of the drivers/irqchip > directory. The irq driver should idealy be there, however this not > trivial at the moment. We still need to support platforms without DT > support and the interface to the DDR controller still use a custom > arch specific API. > > For now just redefine the IRQCHIP_DECLARE macro to avoid the cross > tree include.
The macro has been moved to linux/irqchip.h.
But even if it would still be in drivers/irqchip such a redefine is even worse than the ../../... include. And the proper solution from the very beginning would have been to move the macro to the global header instead of this horrible include.
Sigh,
tglx
| |