Messages in this thread Patch in this message | | | From | Johannes Thumshirn <> | Subject | [PATCH] st: Destroy st_index_idr on module exit | Date | Wed, 8 Jul 2015 17:24:01 +0200 |
| |
Destroy st_index_idr on module exit, reclaiming the allocated memory.
This was detected by the following semantic patch (written by Luis Rodriguez <mcgrof@suse.com>) <SmPL> @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@
module_init(init);
@ defines_module_exit @ identifier exit; @@
module_exit(exit);
@ declares_idr depends on defines_module_init && defines_module_exit @ identifier idr; @@
DEFINE_IDR(idr);
@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ identifier declares_idr.idr, defines_module_exit.exit; @@
exit(void) { ... idr_destroy(&idr); ... }
@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@
exit(void) { ... +idr_destroy(&idr); } </SmPL>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/scsi/st.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 3f25b8f..79ac024 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -4427,6 +4427,7 @@ static void __exit exit_st(void) unregister_chrdev_region(MKDEV(SCSI_TAPE_MAJOR, 0), ST_MAX_TAPE_ENTRIES); class_unregister(&st_sysfs_class); + idr_destroy(&st_index_idr); printk(KERN_INFO "st: Unloaded.\n"); } -- 2.4.3
| |