Messages in this thread Patch in this message | | | From | Johannes Thumshirn <> | Subject | [PATCH] power: bq27x00_battery: Destroy battery_id IDR on module exit | Date | Wed, 8 Jul 2015 17:18:20 +0200 |
| |
Destroy battery_id IDR on module exit, reclaiming the allocated memory.
This was detected by the following semantic patch (written by Luis Rodriguez <mcgrof@suse.com>) <SmPL> @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@
module_init(init);
@ defines_module_exit @ identifier exit; @@
module_exit(exit);
@ declares_idr depends on defines_module_init && defines_module_exit @ identifier idr; @@
DEFINE_IDR(idr);
@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ identifier declares_idr.idr, defines_module_exit.exit; @@
exit(void) { ... idr_destroy(&idr); ... }
@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@
exit(void) { ... +idr_destroy(&idr); } </SmPL>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/power/bq27x00_battery.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c index b6b9837..99180d2 100644 --- a/drivers/power/bq27x00_battery.c +++ b/drivers/power/bq27x00_battery.c @@ -1106,6 +1106,7 @@ static void __exit bq27x00_battery_exit(void) { bq27x00_battery_platform_exit(); bq27x00_battery_i2c_exit(); + idr_destroy(&battery_id); } module_exit(bq27x00_battery_exit); -- 2.4.3
| |