Messages in this thread | | | From | Nicholas Mc Guire <> | Subject | [BUG ?] brcmsmac: condition with no effect | Date | Wed, 8 Jul 2015 15:17:40 +0200 |
| |
From: Nicholas Mc Guire <hofrat@osadl.org>
scanning for trivial bug-patters with coccinelle spatches returned: drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c:3391 WARNING: condition with no effect (if branch == else)
added in 'commit 5b435de0d786 ("net: wireless: add brcm80211 drivers")'
drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c:wlc_lcnphy_deaf_mode() (line numbers are from linux-next v4.2-rc2) 3391 if (LCNREV_LT(pi->pubpi.phy_rev, 2)) { 3392 mod_phy_reg(pi, 0x4b0, (0x1 << 5), (mode) << 5); 3393 mod_phy_reg(pi, 0x4b1, (0x1 << 9), 0 << 9); 3394 } else { 3395 mod_phy_reg(pi, 0x4b0, (0x1 << 5), (mode) << 5); 3396 mod_phy_reg(pi, 0x4b1, (0x1 << 9), 0 << 9); 3397 }
Can't figure out what the intent of this condition is but it currently has no effect as if == else and this most likely is not the intent.
| |