Messages in this thread | | | Date | Mon, 6 Jul 2015 15:21:30 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2] sched/deadline: Remove a redundant condition from task_woken_dl() |
| |
On Sat, 4 Jul 2015 15:39:23 +0800 Xunlei Pang <xlpang@126.com> wrote:
> From: Xunlei Pang <pang.xunlei@linaro.org> > > p has been already queued at this point, so "!task_running(rq, p)" > and "p->nr_cpus_allowed > 1" imply that "has_pushable_dl_tasks(rq)" > is true, so it can be removed.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> > Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org> > --- > kernel/sched/deadline.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 0a17af35..20772ee 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -1657,7 +1657,6 @@ static void task_woken_dl(struct rq *rq, struct task_struct *p) > { > if (!task_running(rq, p) && > !test_tsk_need_resched(rq->curr) && > - has_pushable_dl_tasks(rq) && > p->nr_cpus_allowed > 1 && > dl_task(rq->curr) && > (rq->curr->nr_cpus_allowed < 2 ||
| |