Messages in this thread Patch in this message | | | Date | Wed, 22 Jul 2015 18:05:53 -0400 | From | Tejun Heo <> | Subject | [PATCH block/for-linus] blkcg: fix gendisk reference leak in blkg_conf_prep() |
| |
When a blkcg configuration is targeted to a partition rather than a whole device, blkg_conf_prep fails with -EINVAL; unfortunately, it forgets to put the gendisk ref in that case. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org> Cc: stable@vger.kernel.org --- block/blk-cgroup.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
--- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -791,8 +791,12 @@ int blkg_conf_prep(struct blkcg *blkcg, return -EINVAL; disk = get_gendisk(MKDEV(major, minor), &part); - if (!disk || part) + if (!disk) return -EINVAL; + if (part) { + put_disk(disk); + return -EINVAL; + } rcu_read_lock(); spin_lock_irq(disk->queue->queue_lock);
| |